Skip to content
Submitted about 1 year ago

Responsive layout using HTML & CSS

Martin Tejeda•30
@mawrs
A solution to the Social links profile challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of some of the CSS modifications I was able to make. I realize this goes beyond the scope of the task, but I enjoyed it.

What challenges did you encounter, and how did you overcome them?

The biggest challenge was figuring out how to organize the buttons. I ended up going with a list and putting every "button" in that list. So technically, not buttons I guess.

What specific areas of your project would you like help with?

I'd like more help with making these buttons work. That's more about JS, but I feel like I am ready for it.

Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Daniel 🛸•44,740
    @danielmrz-dev

    Hello there!

    Congrats on completing the challenge! ✅

    Your solution looks great!

    I have a suggestion for improvement:

    📌 Think about using <main> to wrap your main content instead of <div>.

    Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

    This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

    Hope that's helpful!

    Keep up the great work!

    Marked as helpful
  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have a suggestion regarding your code that I believe will be of great interest to you.

    MAKING ACCESSIBLE LINKS:

    • The links like Github, Frontend Mentor li are needed to be actual <a> elements which wrapped using li elements.
    • This is the current markup,
    <ul>
     <li>GitHub</li>
     <li>Frontend Mentor</li>
     .....
</ul>
    • In order to make this solution accessible, we need to use <a> elements with href attribute. Here's the example
    <ul>
     <li>
         <a href="#">GitHub</a>
     </li>
     <li>
          <a href="#">Frontend Mentor</a>
     </li>
     .....
</ul>
    • If you have any questions or need further clarification feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord