@VCarames
Posted
Hey @vanzasetia! "Great looking site!
I used my mac's "Voice Over" and "Tab" button to navigate you site and I had no issues at all. I was able to navigate from the header all the way down to the footer and I was able to open all the buttons.
Why use Divs for the "sections" instead of the Section Elements?
The only thing I would improve is wrapping the address and phone number in Anchor Tags and set their Href in this manner so users can click on them and the phone/address app can open automatically:
Phone:
<a href="tel:+1-543-123-4567">Phone: +1-543-123-4567</a>
For the address you can use any map you prefer, I used Google Maps for the example.
Address:
<a href="http://maps.google.com/?q=987 Hillcrest Lane
Irvine, California 92714 ">987 Hillcrest Lane Irvine, California 92714</a>
For the social media icons I would give them a target="_blank" rel="noopener noreferrer"
so they can open on a new tab. Making it easier for the user to go back to you site.
Happy Coding! π»π
Marked as helpful
@vanzasetia
Posted
Hello, @vcarames! π
Thank you for the feedback! Also, thank you for checking my site with VoiceOver! I am glad to know that you found no issues. π
I use div
instead of section
because it's the same. Whether I use section
or div
, it has no impact on the accessibility of the site. It won't cause issues or make it more accessible.
For the phone number, I decided to not wrap it in an anchor tag. It's not part of the interactive element based on the design.
For the address, I didn't know about using Google Maps. Thank you for telling me this! π
For the social media links, I might do that if it is a real website. I think it's better to not have any links that open in a new tab unless the users will lose data. So, a good example is when the users are required to open another webpage while filling out a form.
You can read "G200: Opening new windows and tabs from a link only when necessary | Techniques for WCAG 2.0".
Users can choose to open the link in a new tab if they want to by right-clicking the mouse and then choosing "Open link in new tab" (in Chromium browsers). Or hover over the link, press the Ctrl
key, and click the link. That will also do the same thing.
Happy coding too! π
@VCarames
Posted
@vanzasetia
The article you provide was very beneficial! Did not know that. Thank you!
@EngineerHamziey
Posted
@vanzasetia thanks for providing us with an informative readme π Kindly help me to checkout my solution here π when you have time. Thanks in advance.
@vanzasetia
Posted
@EngineerHamziey
I have provided some feedback. Hope my feedback helps! π
@EngineerHamziey
Posted
@vanzasetia yes thanks alot π I'll follow up soon, I have been busy at work π