Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive News Homepage

@winstein27

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some recommendations for enhancing your code:

  • The logo’s alt tag description needs to be improved upon ⚠️; it should ALWAYS and only state the company’s name.
  • This <ul class="main-nav" should be ⚠️ a nav element.
  • This is NOT❌ how to build a responsive nav. You only need one navigation menu and you will CSS to style it for each layout.
  • The nav toggle button should be built ⚠️ using a button element and it should have an aria-label, aria-expanded and aria-control.
  • The main article (The Bright Future of Web 3.0) should be wrapped ⚠️ inside an article element.
  • The "The Bright Future of Web 3.0?" Is not an h1 heading ❌, it is another article heading. It should be an h2 heading ✅ and there should be a visibly hidden h1 in the site.
  • The "new" section should be built using an unordered list element ⚠️ and have an aria-label.
  • The bottom section should be built ⚠️ using an ordered list and have a visually hidden h2 heading.
  • The headings in your site are being used incorrectly❌ since the h1 heading can only be used once ⚠️ per page.
  • Numbers are never ❌ headings.
  • The “image” / “illustrations in this component are purely decorative⚠️. Their alt tag should be left blank to hide them from assistive technology.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • There is no need to have separate stylesheets ❌, as it can affect site performance. Instead have one single stylesheet ✅.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 👾

Marked as helpful

0

@winstein27

Posted

@vcarames This is not a helpful comment, this is a perfect comment!!! Thank you very much, you showed me a lot to improve.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord