Responsive News Homepage using TailwindCSS.

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted over 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="whole-page-container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  11

  Marked as helpful
• 

  Ayobami Ikuewumi•850

  @Ikuewumi

  Posted over 2 years ago

  Hi 👋. Really nice solution. The only thing I have to say is:

  • I noticed that you placed a max-height on the blog components. This works well for desktop sites, but on smaller devices, it causes some overflow, so you could put the max-height in a media query like md:max-h-28. And generally, unless you are specific about it, I would be wary of setting heights or max-heights. min-heights tend to break less.

  Feel free to ask any questions

  Keep coding👍, Ayobami

  01

  Marked as helpful