Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive News page w/ reactjs, and styled components

#react#styled-components

@BasharKhdr1992

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Your feedback is highly appreciated

Community feedback

Adriano 34,000

@AdrianoEscarabote

Posted

Hi Bashar Khdr, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!

To resolve do this:

<a class="btn-primary">Read more</a>

If we see how the layout is behaving at higher resolutions, with the help of google dev tools, we will see that it is stretching a lot, to solve this we can use a max-width with the value we want the content to stop growing and to center use a margin: 0 auto;

body {
    max-width: 1920px;
    margin: 0 auto;
}

The rest is great!

I hope it helps... 👍

Marked as helpful

1

@BasharKhdr1992

Posted

@AdrianoEscarabote Thank you so much for your valuable feedback. I will use the tips to improve the solution

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord