Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Responsive NFT preview card component

bem, sass/scss
Yejin Han (한예진)•270
@Yejin-Han
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Nothing special.. but I think my work can correspond to all screen widths.

What challenges did you encounter, and how did you overcome them?

I wonder how to make the card responsive and at the same time how to keep the same ratio of the desktop size. So I used vw to correspond to all device widths.

What specific areas of your project would you like help with?

First of all, I'm not English speaker, so please understand it.

I want to know that my coding style in HTML, CSS is acceptable in real work. I'm in web publishing work, and my direct boss told me your style is a bit strange. I don't know where the problem is.

And also, when we build some responsive design, if the width and height of the body or section is full of the screen as they are now, if properties that are not flexible as vw/vh (such as font-size), there is a risk that the text will be pushed out and the content will go out of the screen height. But at the same time, I wonder if it's right to work with vw/vh like what I've done this time.

Thank you for your answer.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Josephine Fitalvo•280
    @fitalvojosephine
    Posted about 1 year ago

    Yes. Your code is acceptable. More practice and keep on learning. You may know media queries, flexbox, and grid layout for responsiveness. Just like what I'm currently doing right now.

    #Happycoding

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub