Looking to hire developers?
Any feedback to improve my coding? I don't really know what to ask. Feel free to suggest or recommend anything to improve my css skill. I'm just a newbie dreaming to master css. Anything will be appreciated.
@zyq-m
Posted
Wow that was close enough to design. I have a couple of suggestion here.
If you want your site is close to design, you can change the background-color: hsl(225, 100%, 98%) to background-color: hsl(0, 0%, 100%).
Then, you should set your max-width of order-summary to max-width: 28.125rem probably.
Happy coding evilhare!!
Marked as helpful
@darryncodes
Posted
Hi Evilhare,
You've smashed it, well done.
HTML feedback not CSS i'm afraid. You could clear up your accessibility report using some simple semantic mark up like <main> <footer> etc.
Happy coding 🤙
Marked as helpful
@evilhare
Posted
@darryncodes Yeah I saw this in report and don't have any idea how to solve this. Thank you very much. Now I know what to change in my code. Really appreciated these feedbacks. Nice community we have here. Cheers.
Nice job with the background placement and keeping the card centered in the window. You ended up with a really nice solution. Great Job!! ⭐⭐⭐⭐⭐
Marked as helpful
@evilhare
Posted
@palgramming Wow! thanks my very first feedback since I started coding. I'm really afraid to show my codes to to anyone and this is my first. That's so good to hear. Now I'm hype for the next challenge. It really boost my confidence. Thanks again.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
