@andreasremdt
Posted
Hey @naomidzunic,
Congrats on finishing this challenge, it looks really good! A couple of suggestions:
- As the accessibility report already says, you could use a
main
element for your container instead of adiv
. This ensures that your markup is even more semantic and can be better understood by search engines and screen readers. - The "Change" button inside the plan box is a
p
element, which doesn't really seem to fit here. I think the design means this to be a link or button the user can click on to change the annual plan. So, either ana
or abutton
would be more suitable. If you are using a button, make sure to give it acursor: pointer
, so that the user's mouse additionally indicates that this element is clickable. Right now, it might be confusing for some users. - Your card is nicely centered on the page, but you get scrollbars real soon as you mentioned already. @BenjaDotMin made a great suggestion, I'd go with that one to easily fix it :)
Marked as helpful