Submitted over 2 years ago

Responsive page using css grid

Vishal Kumar• 210

@LahsivK4070

Preview site View code

This is a solution for...

Four card feature section

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

I feels like i did a pretty great job. If i am missing somewhere do let me know. Thanks

Community feedback

Yazdun• 1,310

@Yazdun

Posted over 2 years ago

Hello Vishal 👋 I have one thing to add to argel's great feedback !

instead of using p tag for your headings, use h1 to fix your ACCESSIBILITY issue

Marked as helpful

Vishal Kumar• 210

@LahsivK4070

Posted over 2 years ago

@Yazdun I will take care about that. Thanks

argel omnes• 1,800

@argelomnes

Posted over 2 years ago

Hey Vishal,

Nice work with the layout. For the "missing somewhere", that's probably:

font-sizes
4th card should be labeled as 'Calculator'
horizontal spacing of the cards is too wide

Bonus: since you're using Grid, you can remove card-2 and card-3 from their container and position each where they should be.

Marked as helpful

Vishal Kumar• 210

@LahsivK4070

Posted over 2 years ago

@argelomnes Thanks for your help I missed a lot and didn't even realized it.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord