Responsive page using CSS Grid

Community feedback

• 

  Karim•590

  @yasssuz

  Posted over 4 years ago

  Hello Yolanda,

  Awesome build, but I would change some things:

  • on the element container inside your style.css you wrote align-items: center; and justify-content: center; but you have a display: grid. That's incorrect because align-items: center; and justify-content: center; are a display: flex; property, and not a grid one.
  • inside your container, I would put a max-width: 1150px so it will not expand through the entire screen. but then it will not be centered, so add a margin: auto as well.
  • now your container is attached to the top, no problem, easy fix. Go to your body element and add

      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
      min-height: 100vh;
  

  happy coding and if i was helpful please upvote my comment :)

  12
• 

  Karim•810

  @Karimsamir112

  Posted over 4 years ago

  this is very good, I like it .

  keep going and happy coding

  01