Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive page using CSS Grid

@yornellas

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


General feedback, please

Community feedback

Karim 590

@Galielo-App

Posted

Hello Yolanda,

Awesome build, but I would change some things:

  • on the element container inside your style.css you wrote align-items: center; and justify-content: center; but you have a display: grid. That's incorrect because align-items: center; and justify-content: center; are a display: flex; property, and not a grid one.
  • inside your container, I would put a max-width: 1150px so it will not expand through the entire screen. but then it will not be centered, so add a margin: auto as well.
  • now your container is attached to the top, no problem, easy fix. Go to your body element and add
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
    min-height: 100vh;

happy coding and if i was helpful please upvote my comment :)

1

@yornellas

Posted

@Galielo-App thank you for your considerations. I'll make sure to leave them in mind for my next challenge!

0
Karim 590

@Galielo-App

Posted

@yornellas you're welcome, please upvote my comment to support me :)

0
Karim 810

@Karimsamir112

Posted

this is very good, I like it .

keep going and happy coding

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord