Karim• 590
@Galielo-App
Posted
Hello Yolanda,
Awesome build, but I would change some things:
- on the element container inside your
style.css
you wrotealign-items: center;
andjustify-content: center;
but you have adisplay: grid
. That's incorrect becausealign-items: center;
andjustify-content: center;
are adisplay: flex;
property, and not a grid one. - inside your container, I would put a
max-width: 1150px
so it will not expand through the entire screen. but then it will not be centered, so add amargin: auto
as well. - now your container is attached to the top, no problem, easy fix. Go to your body element and add
display: flex;
align-items: center;
justify-content: center;
flex-direction: column;
min-height: 100vh;
happy coding and if i was helpful please upvote my comment :)
1
Yolanda Ornellas• 40
@yornellas
Posted
@Galielo-App thank you for your considerations. I'll make sure to leave them in mind for my next challenge!
0
Karim• 590
@Galielo-App
Posted
@yornellas you're welcome, please upvote my comment to support me :)
0