Responsive page using CSS grid

Please log in to post a comment
Log in with GitHubCommunity feedback
- @Bayoumi-dev
Hey!
- Using more than one
<h1>
is allowed by the HTML specification, but is not considered a best practice. Using only one<h1>
is beneficial for screenreader users.
---> Multiple
<h1>
elements on one pageHope this help!... Keep coding👍
Marked as helpful - Using more than one
- @denielden
Hey Siddhi, congratulations on completing the challenge! You did a great job 😉
Let me give you some little tips for optimizing your code:
- Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - add
main
tag and wrap the card for improve the Accessibility - to make it look as close to the design as possible add
hover
state with border tobutton
element - use
min-height: 100vh
to body instead ofheight
Hope this help! Happy coding 😁
Marked as helpful - Tip of graphic design: with
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord