Responsive page using flexbox

Please log in to post a comment
Log in with GitHubCommunity feedback
- @denielden
Hello Pedro, You have done a good work! 😁
Some little tips to improve your code:
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all
margin
fromqr-container
class because with flex they are superfluous - use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful - use
- @rachit0706
Congratulations for completing the challenge! . Everything looks great but the only issue I found was that you forgot to use
flex-direction: column;
inside the body tag. This will properly center the component in the page and will match the design.Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord