Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive page, using html5, css3, jquery

#jquery

@ArtemPonomarenko

Desktop design screenshot for the GitHub user search app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey guys, This is my first javascript "heavy" project. I would appreciate any comments and feedback on the quality of the code. Thanks! =)

Community feedback

P

@daniloparrajr

Posted

I like that your javascript code is readable! My suggestion is to follow the guidelines here https://github.com/ryanmcdermott/clean-code-javascript.

I noticed that some parts of your js code have a chain of else if statements which is not ideal. You can read more here on why - https://dev.to/dglsparsons/write-better-code-and-be-a-better-programmer-by-never-using-else-statements-4dbl

Also, it is ideal to ditch jquery in today's standard as modern javascript can pretty much handle all that you need. You can check some alternatives here - https://youmightnotneedjquery.com/

If you want to make your JavaScript knowledge better I recommend this course https://learnjavascript.online/

I hope this are all helpful! happy coding!

Marked as helpful

1

@ArtemPonomarenko

Posted

@daniloparrajr, Thanks! I really appreciate the reading materials

0

@elroytoscano

Posted

Works perfectly. Well done 👍

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord