Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Page using semantic elements in HTML5, SCSS and ES6

#accessibility#sass/scss#bem
xZAYEDxβ€’ 250

@xZAYEDx

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Open for criticism 😁 Let me know if i have made any errors in my JavaScript and what could have I done to avoid it🎯

Community feedback

Nguyen Nguyenβ€’ 340

@jesuisbienbien

Posted

Hi Zayed,

Congrats on completing this challenge. Though, I believe there're a few things you need to fix:

  • There's something wrong with the submit button and the illustration. On desktop, the illustration is underneath the submit button, and vice versa for the mobile view. They should be a few rem apart instead of lying on top of e/o.

  • When you submit a blank input, the error message is supposed to say "Whoops! It looks like you forgot to add your email". You can find the instruction under the README.md file.

  • When I submitted an incomplete email (i.e. mail@mail ), it's supposed to be error but it turns blue instead.

  • The submit button should have a box-shadow.

If you have any questions, let me know. I also completed this challenge recently. You can check it out under my profile.

Happy coding :D

Marked as helpful

0
Qstar12β€’ 70

@Qstar12

Posted

Great job!

1

xZAYEDxβ€’ 250

@xZAYEDx

Posted

@Qstar12 thanks bro!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord