elahe• 50
@elahemirzaee
Posted
Well Done Hana :) I can see an html issue in your solution, it says that you have entered " \ " instead of "/" in your link tag in href attribute. Good Luck :D
1
Looking to hire developers?
Any suggestions are welcome ☺
@elahemirzaee
Posted
Well Done Hana :) I can see an html issue in your solution, it says that you have entered " \ " instead of "/" in your link tag in href attribute. Good Luck :D
@vanzasetia
Posted
Hi, Hana! 👋
Here are some suggestions for improvements.
menu
element is the same as the ul
element. It means that it only tells screen readers that it is a list of three items instead a list of three choices. Also, I can't interact with the list using a keyboard. I recommend taking a look at the W3C example of creating custom select.It's time-consuming to open one by one the Sass files and also not everyone understands Sass. So, I recommend providing the non-minified CSS to allow mentors to give feedback on the CSS code.
Hope this helps!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord