Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive page with flexbox

@fvaldes0109

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please let me know what do you think

Community feedback

P
Ken 4,915

@kens-visuals

Posted

Hey @fvaldes0109 👋🏻

I just have a small suggestion for the project.

  • The social links, could be in ul and each li could have <a> tag that can either take to empty pages of the websites accordingly or just point to nowhere href="#". This would be semantically correct.
  • The icons should have aria-hidden="true" and if you choose to implement my suggestion, make sure to add aria-label for the <a> tags that would have the names of the icons, such as, aria-label="facebook" and like so for the other two icons.

I hope this was helpful 👨🏻‍💻 other than that, you did an excellent job, nicely done. Cheers 👾

Marked as helpful

2

@benjoquilario

Posted

Hello Fernando 👋

Everything looks good and I like you solution. Much better than me when I did this challenge😅.

My only small suggestion is:

  • Instead of using <div> elements to wrapping your svg logos you should use anchor element <a> because this element is going to transfer user somewhere.

Keep coding and happy coding too!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord