Hey @fvaldes0109 👋🏻
I just have a small suggestion for the project.
- The social links, could be in
ul
and eachli
could have<a>
tag that can either take to empty pages of the websites accordingly or just point to nowherehref="#"
. This would be semantically correct. - The icons should have
aria-hidden="true"
and if you choose to implement my suggestion, make sure to addaria-label
for the<a>
tags that would have the names of the icons, such as,aria-label="facebook"
and like so for the other two icons.
I hope this was helpful 👨🏻💻 other than that, you did an excellent job, nicely done. Cheers 👾
Marked as helpful
2