Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive page with Grid, Flexbox and Javascript

Daniel 60

@danpth

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


First time using JavaScript, is it good?

Community feedback

James 35

@NaetharuCodes

Posted

Looking at the JS for validation, you have a monster of nested if/else clauses.

I would try and avoid this if possible.

For doing the validation, you don't really need to do it all in one big clause like that. You could just break it down and run one simple clause for each part.

That way it will be much easier to read, and much easier to maintain should you come back to this.

0
Matias 170

@MatiasEmiliano

Posted

Hi, Daniel: Good job! Works well, but a few comments:

  • The form isn´t in the middle of the screen (Verticaly).

  • When the validation is wrong and "Wrong Name" "Wrong email" ...etc apears, the form grows verticaly and don´t look good!

Hope you can improve! By! Keep Developing!

0

James 35

@NaetharuCodes

Posted

@MatiasEmiliano

The vertical growth is part of the design I think. The Figma shows it doing this. I agree it looks weird. But it is correct.

0
Dharmik_487 1,740

@Dharmik48

Posted

Hey👋,

Good job with the solution! Looks nice, I just have a couple of things I think you can improve:

  • At around 930px screen width, the form looks very thin, so I think you should increase the width a bit.
  • Also it would be good if you add transition on hover state.

Keep Developing👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord