Responsive Perfume Card Component built using CSS grid & @media

Community feedback

• 

  Martin Kutzner•600

  @mfkutz

  Posted about 2 years ago

  hello!! do you have 2 identical MQ, for something special? you can put everything inside one, it is also recommended to put some css under them (media queries) good job!

  01
• 

  Joachim•840

  @Thewatcher13

  Posted about 2 years ago

  HTML

  • there should be a main landmark element in your html
  • Why do you have a div that is closed in the same line class=product img?
  • You can't have more than one h1 on a project
  • for the old price use the s tag in html
  • you should use the picture element in your html for your pictures, place them not in the css and absolute not as a background...it is no background..Just a product photo.

  CSS

  • Why do you have a strong element in your css as selector? You haven't one in the html..
  • dont set font size in absolute values (px) but in relative values (rem) https://fedmentor.dev/posts/font-size-px/
  • set your media query in rem to instead of px
  • Use a css reset (in every project) look on Andy Bell his website for a good and clear one

  02