Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Responsive preview card using HTML and CSS

Maria Vivi•50
@mariapaulav
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted over 2 years ago

    Hello

    In html

    • use the picture element not two img tags like this. That lets the browser select the images correctly for you
    • img alt text should describe what the image actually looks like (briefly)
    • you have opened a paragraph tag for perfume but closed a h6. It should be a paragraph
    • that paragraph should not be capitalised in the html. Let the css capitalise it
    • you shouldn’t ever have text in a div or span alone. Wrap those prices in a paragraph tag
    • the old price needs to be wrapped in a del element.
    • I recommend also adding some additional informative text to the del element via before and after pseudo elements, a technique demonstrated on Adrian Rosellis site. So you would have del:before { content: “[deletion start]”. This greatly benefits screenreaders because they are not reliably told when deletions start or end, and are not told when text is styled with a line through, so there would be no way for them to know which is the old price without this extra effort
    • the icon in the button is decorative so alt should be empty
    • I recommend making attribution a footer. It’s not really relevant to the main content
    Marked as helpful
  • P
    Astar•170
    @astaba
    Posted over 2 years ago

    Hola señora. Muy bien hecho, para una principiente ya nos depara muchas promesas sus futuro en el IT.

    1. Le aconsejo añadir un "media query" para cumplir con los requisitos del "Responsive Web Design".
    2. Antes de usar position: absolute es mejor dominar el uso de display: flex del que se puede sacar mucho provecho. Le propongo disfrutar de este Flexbox tutorial.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub