Frontend Mentor | Responsive Product Card coding challenge solution

Community feedback

@correlucas

Posted over 1 year ago

👾Hello @kenankevric, Congratulations on completing this challenge!

Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

The image was not displaying due an error of the location of the file, here's the correct import:

  <img class="parfum-img-desktop" src="/Product-Preview-Card/images/image-product-desktop.jpg" alt="de-parfum-img">
  <img class="parfum-img-mobile" src="Product-Preview-Card/images/image-product-mobile.jpg" alt="de-parfum-img">

Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

✌️ I hope this helps you and happy coding!

Marked as helpful

Kenan• 20

@kenankevric

Posted over 1 year ago

Hi @correlucas, thank you for your feedback.

I will use <main> instead of <div>. Thanks for the suggestion.

For some reason, GitHub is not displaying images. It displayed for a minute and not working anymore. I even tried to change it with a full path and still not working. I saw some members are reporting the same issue on Stack Overflow.

Adriano• 33,960

@AdrianoEscarabote

Posted over 1 year ago

Hi Kenan, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- Document should have one main landmark, you could have put all the content inside the main tag click here

2- All page content should be contained by landmarks, you can understand better by clicking here: click here

We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:

<body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

<body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

The rest is great!!

Hope it helps...👍

Responsive Product Card

Design comparison

Community feedback

Please log in to post a comment

Join our Discord community