Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive product card built with pure css and html

@alecanonm

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Howdy πŸ‘‹πŸ»!

I manage to do this challenge with my knowledge of css and htm, i put all my best practices on it, if you can give me a feedback, tips or any recommendation i'll be really happy...

greeting! πŸš€πŸŒ±

Community feedback

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

Unfortunately, there are numerous aspects that require improvement. I recommend reading this excellent article as it demonstrates how to correctly structure your HTML for this particular challenge.

How to plan your HTML (1): Product Preview Card

As for you CSS:

  • In modern Web Development, all content is built mobile first, in which you style for small screen first and use media-query to style for larger screens. This will ensure that performance and responsiveness are prioritized.
  • Font-size should always be in rem as this helps with accessibility.
  • The height: 100vh; in the body should be a min-height instead for improved responsiveness.
  • There's is no need to apply border-radius multiple times, just apply it to the card container along with overflow: hidden
  • Avoid using static properties as they negatively affect responsiveness.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸ‘Ύ

Marked as helpful

1

@alecanonm

Posted

Thank so much, I’ll be in contact with you later πŸ‘Ύ@vcarames

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord