Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Responsive Product Card - First attempt

LorenaFrias•80
@LorenaFrias
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Wonderful challenge for a newbie! I couldn´t place the icon properly. I came up with a dubious solution using grid. Can anyone point me in the right direction? I'm interested in making it accesible but not sure how to. Any suggestions? Since this is my first challenge feedback is always welcome!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Amparo•80
    @amparoamparo
    Posted over 2 years ago

    Hola de nuevo! :)

    Glad it was helpful.

    Do you mean for screen readers? You could do something like adding a <span> and making it only visible for screen readers. See https://a11y-guidelines.orange.com/en/web/components-examples/accessible-hiding/.

    I think I wrote something like "Reduced from " as the hidden text on my solution.

    Hope that helps!

    Marked as helpful
  • Amparo•80
    @amparoamparo
    Posted over 2 years ago

    Hola Lorena!

    Great job! It looks pretty much the same as the original.

    For the button, I'd say flexbox would probably work better. At least that's what I did when I completed this challenge 😅. That way the text and the icon will be centered more easily, and it will look better when resizing the viewport.

    I'm no expert, but from what I understand, you'd use grid for things that are more rigid, like layouts, where you want the parent to be in control; and flexbox for things that are meant to be FLEXible, like page components, where the children will be more independent.

    The other details I would work on to make it look exactly like the original would be:

    • making the heading slightly smaller,
    • increasing the line height for the main/paragraph text, and
    • fixing the layout so that the two sides are the same size (on desktop).

    Did you have any specific questions about accessibility? You can fix the error showing on your report by adding an empty alt tag (alt=""), since the icon is only decorative and doesn't need to be communicated to screen reader users 😊

    Keep up the good work! 👏

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub