@correlucas
Posted
👾Hello @Carolkiarie, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
1.Add the website favicon inserting the svg image inside the <head>.
<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">
2.The image is getting distorted, to avoid this behavior, use these steps, first add display: block and max-width: 100% to the <img> selector. To improve the responsiveness even more by adding the auto-crop property you can add object-fit: cover to make the image crop inside the container. Here’s the code:
img {
display: block;
object-fit: cover;
max-width: 100%;
}
3.Use the **THE PICTURE TAG** that is a shortcut to deal with the multiple images in this challenge. So you can use the `<picture>` tag instead of importing this as an `<img>` or using a div with `background-image`. Use it to place the images and make the change between mobile and desktop, instead of using a `div` or `img` and set the change in the css with `display: none` with the tag picture is more practical and easy. Note that for **SEO / search engine** reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the `<picture>` tag and use the html to code to set when the images should change setting the device `max-width` depending of the device **desktop + mobile**.
Check the link for the official documentation for `<picture>` in **W3 SCHOOLS**:
[`https://www.w3schools.com/tags/tag_picture.asp`](https://www.w3schools.com/tags/tag_picture.asp)
See the example below:
👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1
✌️ I hope this helps you and happy coding!
Marked as helpful
@Carolkiarie
Posted
@correlucas Hey Lucas. Thank you so much for the suggestion. let me make the changes. Ihad previously not noticed that the image is getting distorted. And i have just tried to look at your solution for the same challenge. however, the link is not working.
