Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 12 months ago

Responsive product preview card component

bem
Luqman (Luke)•320
@luqmanx1998
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

My first challenge on Frontend Mentor !

I'm proud of taking the time to make it look as close to the design as possible, without using the figma file. If I were to do something differently next time, I would probably spend less time trying to get the perfect spacing sizes as it's probably impractical to spend hours trying to make it look perfect. That being said , I would love some kind of code review by anybody to help me improve my code :D. On to the next one.

What challenges did you encounter, and how did you overcome them?

I actually had issues with responsive images, but I managed to fix those by reading up on mdn web docs.

What specific areas of your project would you like help with?

Any kind of code review and feedback at all would be appreciated. Although for such a small project such as this one, I'm not surprised if no one takes a look haha !

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Dylan de Bruijn•3,220
    @DylandeBruijn
    Posted 12 months ago

    @luqmanx1998

    Hiya! 👋

    Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

    Things I like about your solution 🎉

    • Use of semantic HTML elements
    • Clear descriptive CSS classes
    • Use of CSS custom properties
    • Use of relative CSS units
    • BEM
    • Use of the picture element

    Things you could improve ✍️

    • I suggest using a p tag for the header.

    I hope you find my feedback helpful! 🌟

    Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

    Happy coding! 😎

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub