Responsive Product preview card component

Community feedback

• 

  Alex•3,130

  @Alex-Archer-I

  Posted about 1 year ago

  Hi!

  Good job, congrats =)

  You have already been told about fonts, but I want to add a couple suggestions.

  • Use rem values for font sizes. It's a relative units, which value depends of user's font settings, so they provide a better UX.
  • You can use picture tag to dynamically switch images on different versions.

  <picture>
      <source srcset="mobile.jpg" media="(max-width: 900px)">
      <img src="desktop.jpg" alt="">
  </picture>
  

  • And I'm not really sure about type="submit" of the button. Usually this type used inside forms. Also this project is out of context, so we don't know whether this button updates cart locally or send data to the server. Actually, that's not a big deal, just be aware =)

  Overall it's a great work, keep doing =)

  12

  Marked as helpful
• 

  gakrita•140

  @gakrita

  Posted about 1 year ago

  Hi, there! You should insert the font-family: "Montserrat", sans-serif; in the body and font-family: "Fraunces", serif; in the .header. Keep going!

  10
• 

  WXSanchez•80

  @WXSanchez

  Posted about 1 year ago

  I think you just forgot to add the fonts in. But other than that looks great!

  10