Responsive Product preview card component using CSS grid and flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00
• 

  _nehal💎•6,710

  @NehalSahu8055

  Posted about 2 years ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  ➨ Replace height:100vh to min-height:100vh to properly center the card.

  body{
  min-height: 100vh;
  }
  

  ➨For non-decorative images give meaningful and descriptive alt like alt= "Gabrielle chanel Perfume product of london".

  ➨It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.

  <picture>
  <source media="(min-width:800px)" srcset="yourimage.jpg">
  <img src="yourimage.jpg" alt="description">
  </picture>
  

  ➨ Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

  link.

  ➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

  I hope you find this helpful.

  Happy coding😄

  00