Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Responsive Product Preview Card Component with Darkmode using SASS

accessibility, sass/scss
Maame Yaa Serwaa Bona-Mensa•70
@mbonamensa
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I started the project mobile-first and I struggled a little switching from using <img> to background-image because I realized there had to be a change in images in the desktop view. I'd like to know if anyone used <img> all the way for both mobile and desktop and how you went about it. Also please feel free to point out any best practices I may have missed. Thanks.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted almost 3 years ago

    Hi @mbonamensa 👋, good job for completing this challenge!

    In addition to the above comments and answering your question, you can use <picture> tag when you need to change the image on different viewports, using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from using a media query to modify the image More information here

    Example:

    <picture>
       <source media="(max-width: 545px)" srcset="./img/image-product-mobile.jpg">
       <img src="./img/image-product-desktop.jpg" alt="your_alt_text">
    </picture>
    

    In this solution you should not use the background property to set the image because this image has an important semantic meaning, use CSS background property if the image is not part of the content.

    Good Job and happy coding !

    Marked as helpful
  • Tertsegha Kpughur-Tule Moses•210
    @Mosestule2003
    Posted almost 3 years ago

    Hey 👋, really love your solution 👌. Just a few tips that can help out.

    • I noticed you added a feature to your work to alternate background colors. Try adding a box shadow to your card container to express it more on the white background.
    • Also in terms of using image, what I usually do is create a custom image class and assign it to my desired image element. Then in css I add ( width: 100%, height: 100%, and object-fit: cover:). This works really well, and I can persist the custom image name wherever I want to use an image element. Hope this helped, happy coding 👨🏾‍💻👍
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub