Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Responsive Product Preview Card Page

Nicholas Albuquerque•270
@nicoams
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello guys!

I had some doubts while working on this project and I hope you could help me with them:

  1. About the nesting on HTML: I only used divs to contain the elements, including the ones that work as background and as the box to hold the major information about the product ("image" and "infos"). Is there any other feature that works best for this purpose and let the divs only for minor elements (paragraphs and links)?

  2. About the CSS: I tried to rearrange the position of the image and text inside the button, but it did not work as I planned. Maybe because it is a link <a></a>. Is there any way to improve that?

That is it. If you have any other tips or observations, please, feel free to share.

Thank you!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Fab•50
    @tdreams
    Posted over 2 years ago

    Hi @nicoams 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

    1. Here are some suggestions you might consider: You can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query to modify the image.

    2. In this challenge, you should not use the background property to set the image because this image has semantic meaning. Use the CSS background property if the image is not part of the content.

    Example:

    <picture>
       <source media="(max-width: 1046px)" srcset="./images/image-product-mobile.jpg">
       <img src="./images/image-product-desktop.jpg" alt="your_alt_text">
    </picture>
    
    

    You could use the <del> tag to display the old price:

    <del>
       <span class="sr-only">Old price: </span>$169.99
    </del>
    

    Note that I added the <span> with the sr-only class to the del element, this will provide more information about what your old price is about.

    Good job, and happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub