Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Responsive product preview card using flexbox

Xavier•140
@xavCS
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi, this is my first solution on Frontend Mentor for the product preview card component The main challenges for me were positioning and layout in terms of responsiveness i.e., using different displays like flexbox

I tried to lay my CSS out in a way that made sense e.g., creating rulesets per element as you go down the card or at least I tried to follow that order (it might be broken a couple times), if anyone has comments on my layout practice I would welcome them.

I probably didn't need to use a main tag in the HTML but I'm not very familiar with accessibility conventions yet, looking to practice that some more after this project

For some reason, I could not get the card to stay centered and the attribution text to stay at the bottom of the screen without something in the layout messing up, could anyone help me out with that?

I think generally this was a nice project and I found sizing to be okay with Figma but maybe I should have relied on it a bit less, I'm not sure if my way of setting widths etc. is the best way, if anyone has a better solution I'd be happy to see it.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    Hello Xavier, congratulations for you first solution and welcome to the Frontend Mentor community!

    Your solution is having this issue because the display:grid; created a default row for the elements, in this case the container and the attribution. Note that you can also consider not using the attribution to don't worry too much about this element. To fix this error the quick way is adding grid-template-rows: 1fr; to the body, note that the attribution will be separated to the container but it will be centered. Put the attribution inside the main tag to have them together and centered. Code below:

    body { display: grid; grid-template-rows: 1fr; }

    Hope it help you bro, keep coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub