Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

Responsive Product Preview Card using Sass

sass/scss
P
Kumani Kidd•170
@amancalledkidd
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am most proud of using the picture element to responsively change the image depending on page size. This was the first time I have used it, it seems a more efficent way of dealing with responsive pages that require multiple images.

<picture>
          <source srcset="./images/image-product-desktop.jpg" media="(min-width:610px)" />
          <source srcset="./images/image-product-mobile.jpg" />
          <img src="./images/image-product-mobile.jpg" alt="Product image" />
</picture>

Next time I will give better class names to my code.

What challenges did you encounter, and how did you overcome them?

I found getting the images to fit the container to be the most difficult. Eventually I found object-fit which helped solved the issue. Will need to look more into styling images in the future

What specific areas of your project would you like help with?

Did I use the picture element correctly?

Also is the scss structure correct?

Any suggestions on improving code?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grego•1,430
    @Grego14
    Posted 4 months ago

    Hello! Congratulations on completing the challenge. 🎉

    You made a correct use of the picture element and I wanted to tell you that it is not necessary to place the <source> of the image that you place as fallback because if no <source> complies with the media-query the fallback will be used.

    This example will do the same as yours:

    <picture>
      <source srcset="./images/image-product-desktop.jpg" media="(min-width:610px)" />
      <img src="./images/image-product-mobile.jpg" alt="Product image" />
    </picture>
    

    To remove the space created below the image you can use vertical-align: middle; on the <img> element.

    I suggest you use min-height: 100vh; Instead of height: 100vh; since on mobile devices the content is cut off, and it's impossible to see the full button.

    I hope this helps! 😁

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub