@0xabdulkhalid
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
ID ATTRIBUTE 🛑:
- The
id
attribute uniquely identifies elements on a page. It does not make sense to duplicate anid
.
- Duplicate
id
's can break the accessibility of labels for forms, table header cells, etc.,
- To fix the problem, change an
id
value if it is used more than once to be sure each is unique. Uniqueid
's differentiate each element from another and prevent invalid markup
- Ensures that each element on the page with an
id
attribute has a uniqueid
attribute value.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which causes lacking of landmark for a webpage
- So fix it by replacing the wrapper
<div>
element with the semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful