Mijail Hernandez• 950
@MishaHernandez
Posted
Hi Batool H.
Visually I see it very well. I leave you some observations:
- The use of the
picturetag is not very useful in this context, since the idea is not to group images but rather to use them as abackgroundinbody. - I recommend you center the
.cardcontainer inside body using Flexbox. - You make good use of class names but it would be better if you adapt it to a methodology like BEM :)
Greetings and continue with the challenges!
1
Batool H.• 320
@BatoolHasan
Posted
@MishaHernandez Hello, thank you for your feedback. I have a couple of questions if you don't mind.
- Can you clarify where the
picturetag is? I've used thefigureandimgtags - I have tried to center the card with flexbox, but it was not being centered in the middle of the viewport, can you advise on how to fix that?
0
Mijail Hernandez• 950
@MishaHernandez
Posted
@BatoolHasan Hi,
- Sorry, I confused the figure tag with picture. However I think you shouldn't use the img tag for background images.
- To center the card with Flexbox you first need to assign body a height of 100vh. Currently the body has no height because the card is positioned absolutely and I see that it works, but using flexbox for these cases is a good practice.
1
