@ApplePieGiraffe
Posted
Hey there, Yudi Yoshida! 👋
Well done on this challenge! 👍 Your solution looks good and you've done a nice job in positioning the background images in this challenge (which can be a little tricky)!
The only very minor thing I suggest is to decrease the intensity of the box-shadow around the card component a little bit (as in the original design) and perhaps to use an <article>
for the card itself (since it is a self-contained element) to bump up the semantics of your HTML just a little. 😉
As for flexbox vs. grid, I use both in my projects because they are both such wonderful layout tools. Flexbox is best used for two-dimensional layouts (like simple rows or columns) while grid is better for laying out things like cards (where there will be both columns and rows). I suggest picking the one that seems best for the job! 😀
Hope that helps a little. 🙂
Keep coding (and happy coding, too)! 😁
@yudiyoshida
Posted
Hey @ApplePieGiraffe, thank you for you comment and tips! I've already changed the div.card-container to an article tag and made the shadow a little bit smoother.
Thank you for your opinion about flex vs grid.
P.S.: Your profile card project is awesome! I love that 3D animation!!
Keep coding too! :D