Responsive Project Using CSS and React.

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .contenedor {;
    margin: 20rem auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  01

  Marked as helpful
• 

  Shivangam Soni•1,090

  @ShivangamSoni

  Posted about 2 years ago

  1. You have set the range for Day & Month inputs wrong. It's allowing Day up to 40 & Month up to 14.
  2. If put a date in the future, it shouldn't allow it, but it is allowing it. Like if I put 17-06-2023 it shows the result 0-0-0 but it should show an error that the date can't be in future. It works correctly if I try 2024 or ahead, but If I input a date later in this year it works even though it shouldn't.

  02

  Marked as helpful
• 

  Saad Hisham•1,770

  @Saad-Hisham

  Posted about 2 years ago

  Great wok ✨

  00