Responsive qr code challenge using flex

Community feedback

• 

  atomic-variable•10

  @atomic-variable

  Posted about 1 year ago

  Hi Mikhil,

  Congratulations on completing your first challenge. I've some suggestions that might interest you,

  1. Though you have set the exact width and height as per design, it did not reflect on the website. Because by default in the CSS box model, the width and height you assign to an element is applied only to the element's content box, padding and border will take additional space. Setting box-sizing to border-box would fix this issue for you. For detailed information, refer here.
  2. It is always advisable to add width & height to the images. Apart from matching the design, it allows the element to take up space before it loads and avoid layout shifts.
  3. I noticed a few unused styles in the head tag, it's better to remove them to avoid unnecessary load.
  4. The font import is missing from the head tag. You might need to add something like this in your code

  <link href="https://fonts.googleapis.com/css2?family=Outfit:wght@100..900&display=swap" rel="stylesheet">
  

  I hope my suggestions help you, Happy coding!

  Thanks

  10
• 

  nahuejandro•70

  @nahuejandro

  Posted about 1 year ago

  Hi! first thing, colors are not the correct ones. second thing, you need to fix the padding and margin. third thing, you can try spliting your screen and see the final job so you can compare them. keep going, you are nearly close. bye

  01