Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

Responsive QR Code Component - HTML & CSS

Umair Shakoor•70
@UmairShakoor
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I’m most proud of successfully building a responsive QR Code Card using HTML and CSS. This was my first Frontend Mentor challenge, and I learned how to use Flexbox for layout and make the design pixel-perfect. I also deployed the project live using Netlify, which was a great learning experience.

Next time, I would spend more time planning the layout before writing code. I’d also like to use CSS variables for colors and fonts to make the code more maintainable. Additionally, I want to explore adding animations or hover effects to make the design more interactive.

What challenges did you encounter, and how did you overcome them?

One of the main challenges I faced was making the QR Code Card responsive. At first, the layout looked good on desktop but broke on mobile. I overcame this by using media queries to adjust the card’s width and font sizes for smaller screens.

Another challenge was positioning the elements correctly. I struggled with aligning the text and image perfectly. To solve this, I referred to Flexbox documentation and used justify-content and align-items to center the card and its content.

Finally, deploying the project was a bit confusing at first. I had never used Netlify before, but I followed a tutorial and successfully deployed my site. It was a great learning experience!

What specific areas of your project would you like help with?

I’d like help with improving the responsiveness of my QR Code Card. Does it look good on all screen sizes, and are there better ways to implement media queries?

I’m also curious about how I can make my CSS code more organized and maintainable. Should I use CSS variables or a preprocessor like SASS?

Finally, I’d like feedback on accessibility. Are there any improvements I can make to ensure my project is accessible to all users?

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Øystein Håberg•13,260
    @Islandstone89
    Posted 5 months ago

    HTML:

    • You don't need to wrap the image in a <div>.

    • Remove the width attribute on the image.

    • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • "Improve your front-end skills by building projects" is a heading. I would make it a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    CSS:

    • Make a habit of including a modern CSS Reset at the top of the stylesheet.

    • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

    • Use the style guide to find the correct background-color, and move it from main to body.

    • Use the style guide to find the correct font-family, and remember to specify fallback fonts,in case the font doesn't load on the user's device: font-family: 'Outfit', system-ui, sans-serif;. The font-family should not be set on *, but instead on the body.

    • On main, remove width, as it is 100% wide by default. Change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

    • Remove the width in px on the card. We rarely want to give a component a fixed size, as we need it to grow and shrink according to the screen size.

    • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • On the image, add display: block, height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

    Marked as helpful
  • Piotr•260
    @Gwynbleidd222
    Posted 5 months ago

    Everything seems great

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub