Submitted over 1 year ago

Responsive QR Code Component

2trill2code•70

@2trill2code

A solution to the QR code component challenge

Preview Code

Solution retrospective

Are there better ways to do a simple CSS reset?
Is there a better way to vertically and horizontally centre a div?
How was the HTML? Was it semantic enough? How about the class names were they also semantic?
Should all text type elements p, h1 etc. have class names?
Is it a good practice to specify something like h3 compared to .container h3 if you know that one h3 will be on the page?

Code

Couldn’t fetch repository

Please log in to post a comment

Community feedback

YOPA SEREINA•100
@BRENHINES
Posted over 1 year ago
Hello, your code is well written. As for how to do CSS resets more simply, I don't think there is a simpler way to do it. But if you fond another way to make it simply, please can you share it ? And flex is the simplest way to center a div.

Your Html is quite semantic but the classes names, I find them a little disorganized and non-specific, have you ever tried to learn the formatting of class names?

For SEO you should have an H1 for the title because it will be more referenced.

Best wishes.
Marked as helpful
myrh•100
@myrhisyoinked
Posted over 1 year ago
I prefer to use this method to center container vertically & horizontally
```
body {
  display: grid;
  place-content: center;
  margin: 0;
  min-height: 100vh;
}
```

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord