Skip to content
Submitted 10 months ago

Responsive-qr-code-component

DeadvLoper•70
@DeadvLoper
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • Tiani Pierce•10
    @Tiani91

    The solution differs considerably different from the design in regards to height. Trust me, my height in mine can use some work too, mine is a bit tall. The height makes yours look squished, especially on mobile. On desktop it looks too thin. On mobile the text is correctly placed, it's just not enough margin and padding. On desktop though the text stays within the container, it also does more than 2 lines worth. I would definitely look into the use of VH/VW and REM/EM over PX for sizing including padding and margin. Otherwise it looks good. Did you not do a footer to show the attribution?? I'd also look into a Modern CSS Reset, this one was provided to me in feedback I received.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord