Responsive QR Code Component

Community feedback

• 

  Andy•520

  @AndyAshley

  Posted about 3 years ago

  Hey Zack! Good job on the challenge! I would suggest a few things for you. Using vw or vh on text isn't a great idea. It does scale, but it gets so tiny that no one could read it. Also if you made your body or main container have a display: flex with justify-content: center and align-items: center and remove position: absolute on the id="base" container, it wouldn't squish like that and it would also remain centered to the page.

  for the html errors, the lang one can be fixed in nextJS by adding this to your next.config.js:

  
  module.exports = {
    i18n: {
      locales: ["en"],
      defaultLocale: "en",
    },
  };
  

  then just make sure all your images have alt tags. :)

  you could also give the card container a max-width to prevent it from getting larger than intended. that way it can only get so big, but can scale smaller if needed.

  I hope that helps! feel free to ask me any questions if ya need to, Happy Coding!

  06

  Marked as helpful