Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

Responsive QR Code Component

Anthony Dorian•30
@Codeur-Omniscient
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Øystein Håberg•13,280
    @Islandstone89
    Posted 9 months ago

    Hi, well done!

    Here are some tips:

    HTML:

    • It's perfectly OK to use a <div> as the card. A <section> is not semantic unless you add a aria-labelledby where the value is the id of the section heading.

    • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    CSS:

    • Including a CSS Reset at the top is good practice.

    • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

    • It's not common to set anything on html. Move font-family to the body, and remove font-size: 10px; - even though changing it makes it easier to convert from px to rem, it's not recommended.

    • .container doesn't need any styles either, so move the properties to body. Remove width: 100% - block elements like body, div, main etc take up the full width of their parent by default. Change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

    • To center the card horizontally and vertically, you can also use Flexbox on the body:

    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100svh;
    
    • Now that you've removed font-size: 10px on the html, you must adjust the max-width on the card to 20rem, which equals 320px.

    • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

    • On the image, add height: auto and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

    • To create the space between the image and the edge of the card, set padding on all 4 sides of the card:padding: 16px;.

    Marked as helpful
  • Violeta•90
    @v-t-9
    Posted 9 months ago

    Hello!

    Congrats on completing the challenge! I noticed something you might find interesting. Consider using semantic HTML tags like <section></section> instead of <div> to wrap the QR card. Some of the benefits of this are: improved search engine rankings and better maintainability.

    Hope you find this helpful!

  • Eyasu•10
    @TheSecondChance
    Posted 9 months ago

    HTML elements effectively, which enhances both accessibility and SEO. Elements like <header>, <main>, <section> Responsive Layout: The layout looks great across various screen sizes, adapting seamlessly from mobile to desktop.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub