Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Responsive QR Code Component

joelani•80
@joelani
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

All feedback is welcome, thank you in advance

What challenges did you encounter, and how did you overcome them?

I think the only problem I faced was centering the card div, it took me a while but after some research, I was able to center it by changing the parent div to flexbox and adding the justify content and align content.

What specific areas of your project would you like help with?

I'm struggling a bit with media queries and could use some guidance.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • atanasov36•660
    @AtanasovCode
    Posted over 1 year ago

    Hey, great solution. Some tips I would like to give you are centered around responsive design.

    Right now the width and height of the card are fixed which is bad practice when it comes to making sites responsive. So instead of proving a fixed height to your card, you should let the content inside determine it's height.

    So instead of doing this:

     width: 315px;
     max-width: 315px;
     height: 484px;
    

    You can instead use padding inside of the card, and apply margin and padding the the children elements inside of the card and this will make the height dynamic and based on the content inside.

    You said you struggled a bit with media queries but they are also very important when it comes to responsive design. You can think of them as breakpoints that get applied whenever a certain width is reached.

    For example you could add this bit of code to your solution that will make the card take up 90% of the screen width if the width of the screen is less than 648px:

    @media (max-width: 648px) {
        width: 90%;
        max-width: 90%;
    }
    

    Good luck and happy learning :)

  • Kishan Upadhyay•10
    @kishanup78910
    Posted over 1 year ago

    dwhdwk

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub