Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

Responsive QR code component | Semantic HTML & Vanilla CSS, BEM

bem
Johan•100
@JohanChereau
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello everyone👋

I'm excited to share my solution to my first challenge on Frontend Mentor! 🎉

  • I would love to hear your feedback on the readability, structure, and overall quality of my code. Improving in these areas is a priority for me, and I'm eager to learn from your insights.

  • Additionally, if you have any suggestions or tips regarding accessibility, responsiveness or anything, please don't hesitate to share them.

Thank you in advance for your time. Your feedback will be invaluable as I continue my journey as a web developer. 🙏

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Account deletedPosted almost 2 years ago

    You nailed it!

    In case you didn't know you can also separate the colors from thehsl function. Having them separately let's you be more flexible with your opacity value.

    Like this:

    :root {
    /* Define just the color values */
    --clr-neutral-700: 218, 44%, 22%;
    }
    
    .title {
    /* Now it's much organized if you want to work with the opacity of the above color */
    --title-text: hsl(var(--clr-neutral-700), 0.8);
        
    color: var(--title-text);
    }
    
    Marked as helpful
  • P
    Chimobi Ekwunife•10
    @MrEkwunife
    Posted almost 2 years ago

    Nice job 👍. I love it

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub