Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Responsive QR code component using CSS Flexbox

Jaheem Prevost•80
@jaheemprevost
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I just couldn't manage to get the next exactly like how it was shown in the design images. I wonder if this is good enough...

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Pradeep Saini•990
    @pradeeps4ini
    Posted almost 3 years ago

    Hi, jaheem.

    You implemented the design pretty well.

    I would like to suggest some changes, that will make the code better.

    • Use semantic markup. For the card component you can use <main>, tag since card is the only main content on the page.

    • In your CSS, you're repeating the styling for .card-component in both the desktop and mobile mode. When you wrote the style outside media query, it will cascade and will be applied in the media query as well. You should only write the properties you want to change. Don't rewrite the properties, you're not changing.

    Marked as helpful
  • Remtaine•360
    @remtaine
    Posted almost 3 years ago

    It looks really good! It's pretty similar to the desktop and mobile design images so I don't think there's a problem. I suggest you add a shadow next time so it looks more like the design

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub