Responsive QR code component using HTML & CSS

Community feedback

• 

  Vincent Daniel•410

  @davinceey

  Posted almost 3 years ago

  Hello Mohit. Congratulations on your first project! This is apt and great on the whole. Just some little tips for improvement:

  1. You might want to replace the p tag used in the first write-up, with a h1 tag, so that your <main> tag, has a level-one heading.

  2. You might as well, want to use more of relative units such as the em and rem in applying to padding, margins, widths and font-sizes. This would help to increase the responsiveness of your layout.

  You did very well. Keep up!

  Hope this helps you. Happy Coding!👊

  12

  Marked as helpful
• 

  Lucas 👾•104,160

  @correlucas

  Posted almost 3 years ago

  👾Hi Mohit, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  Your component is perfect, but is not responsive yet, this is due the fixed width you've applied to the container.

  Look both width and max-width the main difference between these properties is that the first(width) is fixed and the second(max-width) is flexible, for example, a component with width: 320px will not grow or shrink because the size will be ever the same, but a container with max-width: 320px or min-width: 320px can grow or contract depending of the property you've set for the container. So if you want a responsive block element, never use width choose or min-width or max-width.

  Note that there's no need to use height here, because since you set a height for an element, this means that this element will grow until a certain point and after that the inner content (as texts or images) will start to pop out the element due its fixed height, so isn't necessary to set the height the container height comes from the elements, its paddings and height.

  ✌️ I hope this helps you and happy coding!

  13

  Marked as helpful