Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

Responsive QR Code component using media queries

P
Aakash Dasgupta•410
@a-d14
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I would use flexbox next time.

What challenges did you encounter, and how did you overcome them?

I faced challenges mainly with making the QR code component responsive with smaller screen sizes. I solved it by adding a width property along with max-width and using a bunch of media queries.

What specific areas of your project would you like help with?

I know it would have been better if I used flexbox, but I feel the code I wrote could have been written better and more succinctly. I would appreciate if someone could take a look and let me know where I can improve on.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Øystein Håberg•13,260
    @Islandstone89
    Posted 5 months ago

    Hi, good job.

    Here are some suggestions - I hope my feedback is clear and helpful!

    HTML:

    • You don't need to include "image" in the alt text, as "qr code image" would be read by screen readers as "image, qr code image". Also, the alt text must say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    • Wrap the footer text in a <p>.

    • The <footer> must be outside of the <main> - both should be direct children of the <body>.

    CSS:

    • Make a habit of including a modern CSS Reset at the top of the stylesheet.

    • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

    • Move box-sizing: border-box to *, *::before, *::after. Remove the remaining styles on html, as it's not common to set styles on the html. NB: Do not change the font-size to 62.5%.

    • It's common in a CSS Reset to set the line-height on body to 1.5.

    • Remove height: 100% on the body.

    • Remove all positioning and transform properties, as these are not the best options for centering components.

    • To center the card horizontally and vertically, with some space between the <main> and the <footer>, I would use Flexbox on the body:

    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100svh;
    gap: 1rem;
    
    • Remove all widths in %.

    • I would adjust the max-width on the card to around 20rem.

    • Remove the height on the card. You should never limit the height of elements containing text - it will cause overflow if the text grows taller than the fixed size. Let the content decide the height, which it does by default.

    • Since you've removed font-size: 62.5%, the text will probably look a bit too big - I would remove font-size on the heading, paragraph and the footer, as their default font size looks alright.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

    • Descendant selectors like .card-content > p increase specificity, making the styles harder to override. It's best practice to instead give elements a class, and use that as the selector.

    • On the image, add display: block, height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

    • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.

    Good luck :)

    Marked as helpful
  • dilip•130
    @dilip43
    Posted 5 months ago

    the ui is looking good

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub