@PhoenixDev22
Posted
Hi Adeola Ganiu,
Congratulation on completing another frontend mentor challenge. I have some suggestions regarding your solution:
- You did great to make the Qr accessible for for visually impaired users.
- The link wrapping the Qr image should either have
Sr-only
text, anaria-label
or alternate text that indicates where the link navigate the user(not describes the image).
width: 270px
an explicit width is not a good way to have a responsive layout. Consider usingmax-width
to the card inrem
instead.
height: 400px
It's not recommended to set height to component, let the content of the component define the height.
- Consider using rem for font size. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
hopefully this feedback helps.
Marked as helpful
@Deolabest
Posted
@PhoenixDev22 Thanks. I'll correct that.