Responsive QR code

Community feedback

• 

  P

  Trần Thành Danh•1,500

  @TranDanh1122

  Posted 7 months ago

  1. you review code must be your repo url, not profile
  2. let use fontface to load font, not import
  3. image need object fit, and if can, add aspect ratio
  4. let reset css first (*{margin 0 pading 0 boxsizing border-box}), that will help you control spacing.
  5. remember, display flex on your body maybe cause missing content on mobile device if your card higher than 100vh

  hope that help!!!

  10
• 

  Ardian Wicaksono•70

  @Ardianwi

  Posted 7 months ago

  your size is'nt same with design..you can download the design in file design figma..

  00
• 

  Jordan Bugglin•410

  @Jbugglin

  Posted 7 months ago

  The border-radius on the main card looks to be a bit too sharp, might need to increase that value to get a more rounded corner. I like to take the value for the outer radius on the main card and halve it to get the inner radius for the image. That way the corner looks to be a more consistent thickness throughout.

  Source: https://www.uidesign.tips/ui-tips/border-radius-consistency

  Your box-shadow is a bit too dark, not blended as much as the design calls for, nor drops as far down. The values you have is 0px 0px 7px 1px $paraColor. If you want to apply a simple box-shadow, remember that the first value is the offset-x, second is offset-y then blur-radius value and color, no need to overcomplicate it.

  Source: https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow

  As for the h1 and paragraph elements, just adjust the width of the elements to match that of the design.

  You did a great job and keep it up!

  00