@0xAbdulKhalid
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here 📚.
- For this demonstration we use css
Grid
to center the component.
body {
min-height: 100vh;
display: grid;
place-items: center;
}
- Now remove these styles, after removing you can able to see the changes
.card {
margin: 1rem auto;
}
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@Uzmakh
Posted
@0xAbdulKhalid Thanks for your valuable feedback . I have done it in body as you suggested but I am in confusion Can we use display : grid; in body and flex in the card?
@Uzmakh
Posted
.card { width: 380px; margin: 5rem auto;}
Then may I remove the width also when removing the margin? what's the way in the grid to show card-space grid-template-column?