Submitted over 2 years ago

Responsive QR component using Flex

@JudeSavio

A solution to the QR code component challenge

Solution retrospective

Please let me know areas I can improve upon. It'll greatly help if I've adhered to flex best practices. Your Feedback is appreciated!

Code

Please log in to post a comment

Community feedback

Lord Robins•610
@ZenitsuAg
Posted over 2 years ago
Hello Jude, you've done pretty well. Here are some tips to help you improve your code.
- Your image didn't load because you didn't upload the image folder to your repo.
- It's usually better to wrap the entire code inside a main tag for accessibility purposes.
- Also, I see that you aligned the h1 and the p elements in the HTML file , it's much better to do all that in CSS using the text-align property and you can just set it to center
- And I really don't know how but you're missing the HTML boilerplate in your code. I mean
```
<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
</head>
```
this stuff. This is a very important component of any modern website today.

Overall, you've done a great job.

Happy Coding :)
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord