Responsive QR Component with Vanilla HTML+CSS

Community feedback

• 

  Lucas 👾•104,160

  @correlucas

  Posted almost 3 years ago

  👾Hi Emin Bilgen, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  The main heading have the tag <h2>, in this case its better you replace it with <h1> since this heading is the main title in this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence h1, h2, h3, h4, h5 and never jump a level.

  Use relative units like rem or em instead of px to have a better perfomance when you page content resize in different screen and devices. REM and EM does not just apply to font size, but to all sizes as well. To save your time you can code you whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  ✌️ I hope this helps you and happy coding!

  10

  Marked as helpful
• 

  Sanjeet Kumar•30

  @chaursiyasanjeet

  Posted almost 3 years ago

  Hey Emin welcome to front-end mentor family you have ser width in percent actually you have to set width exactly like some 300px; so the qr-code container wpuld have exact size and you have also used many div in your document you just don't need to do that you can do your work with just main element.Please see your code once again because the text and image are comimg outside of container.And if you need any help feel free to dm me.

  10

  Marked as helpful